Skip to content

fix(server): apply thread pool limit carve-out to all of macOS #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hubcio merged 2 commits into from
Aug 31, 2026
Merged

fix(server): apply thread pool limit carve-out to all of macOS #3994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8db0635
resolve panics from macos - x86 on iggy server
djanand Aug 30, 2026
dae651f
Merge branch 'master' into fix/macos-x86-threadpool-limit
hubcio Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/partitions/src/messages_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,9 @@ fn preallocate_file(file: &File, file_path: &str, len: u64) {
// sets `thread_pool_limit(0)` on the shard proactor, so `spawn_blocking`
// has no worker to park a task on and compio panics the shard outright with
// "the thread pool is needed but no worker thread is running". (That limit
// is skipped on macOS/aarch64, where the pool does exist -- see the FIXME
// there -- so the panic is Linux-and-most-targets, not universal. This arm
// is Linux-only regardless.)
// is skipped on macOS, whose polling driver routes fs through the pool, so
// the panic is Linux-and-most-targets, not universal. This arm is
// Linux-only regardless.)
//
// The cost is acceptable only because of what this call is: a metadata-only
// extent reservation, microseconds on the local filesystems this option
Expand Down
2 changes: 1 addition & 1 deletion core/server_common/src/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ pub fn create_shard_executor() -> Result<Runtime, std::io::Error> {
// io_uring targets keep the zero limit: no blocking pool exists on shard
// threads, which `core/partitions` messages_writer relies on to justify
// running fallocate inline (`spawn_blocking` would hit that same panic).
#[cfg(not(all(target_os = "macos", target_arch = "aarch64")))]
#[cfg(not(target_os = "macos"))]
proactor.thread_pool_limit(0);

compio::runtime::RuntimeBuilder::new()
Expand Down
Loading