test(partitions): gate the persist-retry test on Linux - #3998
Merged
Conversation
The retry test reaches for /dev/full, which only exists on Linux, but its #[cfg(target_os = "linux")] gate and doc comment landed on the preceding test instead. macOS builds of the test target failed with E0425 on DEV_FULL. Pre-merge builds macOS without --tests, so the break only surfaced in the post-merge macOS cache warm, which does compile tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3998 +/- ##
=============================================
- Coverage 84.91% 73.90% -11.02%
- Complexity 1405 1406 +1
=============================================
Files 1224 1224
Lines 179327 179327
Branches 145615 145616 +1
=============================================
- Hits 152271 132527 -19744
- Misses 23028 42737 +19709
- Partials 4028 4063 +35
🚀 New features to boost your workflow:
|
Contributor
|
Looks good. Facing the same on ci-pre hooks when merging upstream/master to forked repo. |
spetz
approved these changes
Aug 31, 2026
mmodzelewski
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retry test reaches for /dev/full, which only exists on
Linux, but its #[cfg(target_os = "linux")] gate and doc
comment landed on the preceding test instead. macOS builds
of the test target failed with E0425 on DEV_FULL.
Pre-merge builds macOS without --tests, so the break only
surfaced in the post-merge macOS cache warm, which does
compile tests.