Skip to content

docs(repo): add repo-wide team-review agent skill - #4004

Merged
spetz merged 4 commits into
masterfrom
docs/team-review-skill
Sep 1, 2026
Merged

docs(repo): add repo-wide team-review agent skill#4004
spetz merged 4 commits into
masterfrom
docs/team-review-skill

Conversation

@hubcio

@hubcio hubcio commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

This PR adds a new skill used to review changes.
Contributors are encouraged to use it.

It is placed under .claude/skills/ next to the connector skills.
The report lands in the agent session scratchpad.

Skills carry no disable-model-invocation flag, so the
description states the skill is user-invoked only: one run
spawns roughly ten subagents.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 31, 2026
Comment thread .claude/skills/team-review/SKILL.md
The four-expert review workflow lived only in a personal
~/.claude command with a hardcoded local dump directory, so
nobody else could run it and it never got reviewed alongside
the code it reviews.

Move it under .claude/skills/ next to the connector skills.
The report now lands in the agent session scratchpad rather
than a machine-specific path, and the target argument, the
expert agent names and the no-findings path are spelled out
so a run does not rely on conventions only the original
author knew.

Skills carry no disable-model-invocation flag, so the
description states the skill is user-invoked only: one run
spawns roughly ten subagents.
The description asked the agent not to invoke the skill on its
own, which is prose the agent may ignore, and the commit that
added it wrongly claimed skills have no frontmatter flag for that.

Set disable-model-invocation, which drops the description from the
agent's context and blocks the Skill call outright. AGENTS.md now
says so and asks the agent to suggest /team-review instead of
loading it. The target binds through $ARGUMENTS since /team-review
is the only entry point left.
Experts sometimes reach for cargo test to settle a claim. Parallel
runs from four agents serialize on the target-dir lock and burn
the reading budget. The charter now requires a stated reason
before any test or build run.

The report ends with per-severity counts so the verdict can be
read without scanning the sections.
@hubcio
hubcio force-pushed the docs/team-review-skill branch from 8e70035 to 3ff7671 Compare September 1, 2026 06:12
@spetz
spetz merged commit 72b5995 into master Sep 1, 2026
30 checks passed
@spetz
spetz deleted the docs/team-review-skill branch September 1, 2026 06:32
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants