fix(shard): keep a parked prepare's stamp and op order on re-dispatch - #4005
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4005 +/- ##
============================================
- Coverage 85.00% 85.00% -0.01%
Complexity 1402 1402
============================================
Files 1225 1226 +1
Lines 180283 180538 +255
Branches 146587 146845 +258
============================================
+ Hits 153248 153460 +212
- Misses 22993 23016 +23
- Partials 4042 4062 +20
🚀 New features to boost your workflow:
|
spetz
previously approved these changes
Sep 1, 2026
spetz
approved these changes
Sep 1, 2026
hubcio
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partition prepares can arrive before their namespace is
materialised. Re-dispatch through the shard inbox lost each
frame's original epoch stamp and placed it behind newer frames.
A delete and recreate could therefore serve an old prepare
against the replacement, while the backup gap check could drop
a later operation before the parked prefix reached the plane.
Stage parked frames in a shard-local FIFO and carry their epoch
and park-pass provenance. A biased pump arm processes one
staged frame per iteration after ticks and before inbox work.
This preserves order without delaying heartbeats behind a
bounded queue, and loopback runs after every delivery so a solo
primary commits re-dispatched requests immediately. Shutdown
uses the same ordering.
Simulator materialisation now passes its resolved epoch and
wakes the pump after off-pump staging. Seeded three-replica and
solo-primary tests pin queue ordering, wakeup, loopback, and
deterministic replay. Quiescence rejects stranded redispatch
work.
The integration oracle now filters gap markers to the partition
plane, removes ambient RUST_LOG when an explicit logging level
is configured, and falls back to the server log when verbose
mode inherits stdout. Dropped or rejected staged frames are
counted, and recovery documentation reflects same-view repair.
The shared leader-redirection BDD fixture could elect replica 1
when a loaded runner delayed replica 0 during concurrent
startup. Start replica 1 only after replica 0 is healthy and use
a wider fixture heartbeat window so the scenarios test client
redirection instead of container scheduling.