KNOX-3238: Migrate from javax.servlet to jakarta.servlet servlet-api#1213
Draft
bonampak wants to merge 42 commits intoapache:masterfrom
Draft
KNOX-3238: Migrate from javax.servlet to jakarta.servlet servlet-api#1213bonampak wants to merge 42 commits intoapache:masterfrom
bonampak wants to merge 42 commits intoapache:masterfrom
Conversation
# Conflicts: # gateway-provider-security-jwt/src/test/java/org/apache/knox/gateway/provider/federation/JWTFederationFilterTest.java # gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/ClientCredentialsResource.java # Conflicts: # gateway-spi/src/main/java/org/apache/knox/gateway/util/ServletRequestUtils.java
…sses, deleting NoOpLogger (Log class removed in Jetty 12) and defining log4j2.xml configuration files for tests.
… along with jetty 12 form keys length and size.
…k in Jetty 12, as Jetty will use 1...n threads for a request / response exchange).
…bshellWebSocketAdapter and JWTValidatorFactory.
… KnoxCacheManager and KnoxLdapRealm.
…o a top-level class and correcting WebsocketBackendUrlTest.
…x) and changed to metrics-jakarta-servlets.
…i version for EE10.
…ServiceRoleTest.testGatewayRewriteHttpEcho
…cket.core.OpCode.
…r. (xmlConfiguration.getServiceCreationConfigurations() is unmodifiable in ehcache-3.10.9-jakarta).
Test Results21 tests 21 ✅ 1s ⏱️ Results for commit 6aa8040. ♻️ This comment has been updated with latest results. |
…ndlerQueryStringCredentialAliasCreation.
… using Servlet 6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3238 - Migrate from javax.servlet to jakarta.servlet servlet-api and upgrade jetty to 12.x.
What changes were proposed in this pull request?
Updated javax.servlet dependencies to jakarta.servlet. Jetty 9 was upgraded to Jetty 12 (Handlers, Websocket handling). Some other libraries were also upgraded (shiro, ehcache, jersey, pac4j)
How was this patch tested?
Not tested yet. Websocket-related tests still need to be corrected.