Repository navigation
Port fix for Token's positionLength from Lucene 4.8.1, #1381 - #1421
Merged
Merged
Conversation
18 of 19 tasks
NightOwl888
approved these changes
Aug 30, 2026
NightOwl888
left a comment
Contributor
There was a problem hiding this comment.
Looks like a faithful port of the upstream commit.
I did not check what all of the implications of adding this commit will be, but did ask ChatGPT whether changing GetHashCode() and Equals() will affect binary compatibility of the index and the answer was generally no. But we should probably merge #1351 and rebase this against it to be sure.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport fix for Token's positionLength from Lucene 4.8.1
Partial #1381 (Batch 3)
Description
This backports commit c921f8a009c for LUCENE-5639 from the 4.8.1 release. This fixes usage of Token's positionLength value.