feat(desktop): offer safe resume after user stop - #5207
Open
me2seeks wants to merge 1 commit into
Open
Conversation
Generated-by: OpenAI Codex
me2seeks
added this pull request to stack #5208
September 11, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Offer the existing
Continue this turnaction directly on the Desktop statusnotice produced by the renderer Stop button.
Desktop now treats an aborted Turn as an explicit resume candidate only when
its abort source is
renderer.stop_button. Other cancellation sources remainineligible for this presentation path.
The button reuses the existing Desktop resume controller and
sessions:resumeLatestIPC operation. It does not pre-authorize continuation:the Runtime Host planner still decides whether the stopped Run is safe and
returns the existing refusal reasons when it is not.
This PR is stacked on the explicit-resume policy PR.
Closes #5205
Verification
npm run rebuildnpm --workspace @maka/ui run test:distnpm --workspace @maka/desktop run test:distnpm run check:renderer-architecture -- --base cb3af4b2f24a3ace8d9574ca60396ffc1cc97219npm run lintnpm run format:checknpm run check:asf-headersnpm run check:stalegit diff --checkA packaged Desktop visual smoke test was not run. The button visibility and
click behavior are covered by the DOM interaction regression; the final
placement still needs human UX review.
Hosted CI has not run yet.
Review focus
Please verify that the Stop outcome is the correct place for this action and
that matching
renderer.stop_buttonis sufficiently narrow. The Runtime Host,rather than the renderer selector, must remain the safety authority.
AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex traced the Desktop Stop projection and existing
resume controller, implemented the affordance and regressions, updated the
architecture documentation, and performed adversarial pre-PR review.
Checklist
Does this PR entail a change in behavior?