Skip to content

[fix][misc] Preserve empty String values in FieldParser #26078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hiSandog wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −1
Open

[fix][misc] Preserve empty String values in FieldParser #26078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf504f0
Fix FieldParser empty String clearing
hiSandog Jun 23, 2026
0aaad54
fix(review): preserve empty FieldParser strings on PR #26078
hiSandog Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pulsar-common/src/main/java/org/apache/pulsar/common/util/FieldParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,10 @@ public static <T> void setEmptyValue(String strValue, Field field, T obj)
throw new IllegalArgumentException(
format("unsupported field-type %s for %s", field.getType(), field.getName()));
}
} else if (Number.class.isAssignableFrom(field.getType()) || fieldType.getClass().equals(String.class)) {
} else if (Number.class.isAssignableFrom(field.getType())) {
field.set(obj, null);
} else if (String.class.equals(field.getType())) {
field.set(obj, "");
}
}

Expand Down
12 changes: 12 additions & 0 deletions pulsar-common/src/test/java/org/apache/pulsar/common/util/FieldParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,18 @@ public void testMapWithEqualsSignAndEmptyValue() {
assertEquals(config.stringStringMap.get("key2"), "");
}

@Test
public void testEmptyValuePreservesStringFieldAsEmptyString() {
Map<String, String> properties = new HashMap<>();
properties.put("name", "");

MyConfig config = new MyConfig();
config.name = "configured";
FieldParser.update(properties, config);

assertEquals(config.name, "");
}

@Test
public void testNullStrValue() throws Exception {
class TestMap {
Expand Down
Loading