LinuxContainer/LinuxPod: Make time sync configurable#698
Draft
dcantah wants to merge 1 commit intoapple:mainfrom
Draft
LinuxContainer/LinuxPod: Make time sync configurable#698dcantah wants to merge 1 commit intoapple:mainfrom
dcantah wants to merge 1 commit intoapple:mainfrom
Conversation
Today our time syncing with the host lives in VZVirtualMachineInstance, which means if a user made their own vmm type they would have to roll their own time syncing. It likely makes more sense to hoist this up to LinuxContainer/LinuxPod so if they want it they can use it, and if they have their own synchronization they can just disable it and use whatever they want. This also lowers the default sync period to 20 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today our time syncing with the host lives in VZVirtualMachineInstance, which means if a user made their own vmm type they would have to roll their own time syncing. It likely makes more sense to hoist this up to LinuxContainer/LinuxPod so if they want it they can use it, and if they have their own synchronization they can just disable it and use whatever they want. This also lowers the default sync period to 20 seconds.