Revert postgres-enterprise cluster ID special-casing - #132
Merged
Merged
Conversation
Always require a valid cluster UUID on the license form regardless of product, restoring the Cluster field's binding:"Required" tag and the unconditional uuid.Parse check in Validate(). Also drops the server-side UUIDv7 auto-generation for postgres-enterprise and the form JS that hid the Kubernetes Cluster ID field for that product. Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binding:"Required"onLicenseForm.Clusterand the unconditionaluuid.Parsecheck inValidate()— the Kubernetes Cluster ID is required for every product again, including postgres-enterprise/issue-licensehandlerThis follows up on #131, which is already merged into master; the postgres-enterprise product itself is unaffected — only the cluster-ID special-casing added on top of it is reverted.
Test plan
go build -mod=vendor ./...go test -mod=vendor -race ./pkg/server/.../issue-licensewith product = postgres-enterprise and no cluster ID and confirm it's rejected as required