Skip to content

Fix Milvus object storage secret filter and label #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnobKumarSaha merged 1 commit into from
Sep 5, 2026
Merged

Fix Milvus object storage secret filter and label #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/kubedbcom-milvus-editor-options/ui/create-ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ step:
files and index files. Provide the name of a Kubernetes secret that contains
the MinIO or S3-compatible storage configuration.
type: label-element
- label: Config Secret
- label: Object Storage Secret
loader: getSecrets
refresh: true
schema: schema/properties/spec/properties/objectStorage/properties/configSecretName
Expand Down
6 changes: 4 additions & 2 deletions charts/kubedbcom-milvus-editor-options/ui/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,9 +1074,11 @@ export const useFunc = (model) => {

const secrets = (resp && resp.data && resp.data.items) || []

const requiredKeys = ['address', 'port', 'accessKeyID', 'secretAccessKey', 'bucketName']
const filteredSecrets = secrets.filter((item) => {
const validType = ['Opaque']
return validType.includes(item.type) && Object.keys(item.data || {}).includes('config.env')
if (item.type !== 'Opaque') return false
const keys = Object.keys(item.data || {})
return requiredKeys.every((key) => keys.includes(key))
})

filteredSecrets.map((item) => {
Expand Down
Loading