feat: Implement bulk delete for function deployments using Svelte 5 runes#2983
feat: Implement bulk delete for function deployments using Svelte 5 runes#2983Root-Aamir wants to merge 4 commits intoappwrite:mainfrom
Conversation
Greptile SummaryThis PR adds multi-selection and bulk-delete to the function deployments table and migrates the component to Svelte 5 runes. The previously flagged regressions (cancel button unreachable, missing source-size guard, blank Confidence Score: 5/5Safe to merge; all previously flagged P0/P1 regressions have been addressed and no new blocking issues were found. Every critical concern from the prior review round (cancel button, source-size guard, column rendering, delete guard, try/finally placement, selectedIds typing) is fixed in the current revision. The only remaining gap is the No files require special attention for merge. Important Files Changed
Reviews (4): Last reviewed commit: "fix: move batchDelete inside try block f..." | Re-trigger Greptile |
|
"Updated! I've restored the Cancel action, added back the Redeploy guards (with tooltips), and fixed the missing column rendering for source and build sizes. I've also tightened the types for selectedIds. Ready for another look!" |
|
Done! I've implemented the conditional rendering for Delete and Cancel actions based on the deployment's effective status. |
|
"Great catch! I've moved batchDelete inside the try block. This ensures that invalidate(Dependencies.DEPLOYMENTS) in the finally block always runs to keep the UI in sync, and any errors are properly caught and tracked. Thanks for the thorough review!" |
What does this PR do?
This PR implements the multi-selection and bulk delete functionality for the function deployments table in the Appwrite Console. Key changes include:
Test Plan
Related Issues
Closes #7772

