feat(json-view): separate expand and copy interactions - #1718
Draft
WGB5445 wants to merge 6 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👷 Deploy Preview for aptos-explorer processing.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
==========================================
+ Coverage 38.15% 38.71% +0.55%
==========================================
Files 215 215
Lines 9911 9847 -64
Branches 3866 3834 -32
==========================================
+ Hits 3782 3812 +30
+ Misses 6107 6013 -94
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 6.14MB (57.74%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: aptos-explorer-client-esmAssets Changed:
Files in
view changes for bundle: aptos-explorer-server-esmAssets Changed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: separate long-string expansion from copying, add row-level hover copy buttons for complete raw values, preserve selectable JSON text, add regression coverage, and update the feature spec and changelog. Validation: pnpm fmt passed; pnpm lint passed with existing SVG accessibility warnings; pnpm test --run and the targeted single-file run were blocked by the local EMFILE too-many-open-files watcher limit.