Skip to content

feat(APP-967): Add permissions graph view for DAO settings - #1202

Closed
thekidnamedkd wants to merge 32 commits into
mainfrom
app-967-build-graph-view-for-permission-page
Closed

feat(APP-967): Add permissions graph view for DAO settings#1202
thekidnamedkd wants to merge 32 commits into
mainfrom
app-967-build-graph-view-for-permission-page

Conversation

@thekidnamedkd

@thekidnamedkd thekidnamedkd commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

Enables the Graph toggle on the DAO settings permissions page (present-but-disabled in APP-954) with an interactive React Flow graph.

  • List/Graph toggle wired up via the permissionsview URL param
  • Graph built from permission rows: nodes = DAO / linked DAO / plugin / actor, edges = permissions
  • Node visuals by kind: DAOs → DaoAvatar, plugins → Tag (SPP/MULTISIG), wallets/AnyoneAvatar
  • Edges: source dot + directional arrow (control flow who→where) in every state; selected flow drawn in primary
  • Click a permission → inline detail card (Permission/Condition tabs); who/where nodes tagged, the rest dimmed
  • Dagre auto-layout; selecting freezes the board (manual drag positions preserved) and restores exactly on close

Dependencies

Known follow-up: fitView doesn't zoom-out-to-fit very tall graphs (top node can clip on load).

Type of Change

  • Minor: Feature (non-breaking change which adds new functionality)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console (pre-existing CSP/wallet console noise is unrelated)
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied — node-kind fidelity (DAO/plugin/linked) needs live APP-953 data to fully verify
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules — n/a
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github's UI reflect my intended changes
  • Confirmed the pipeline checks are not failing — pending CI

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

🤖 Generated with Claude Code

thekidnamedkd and others added 21 commits June 30, 2026 10:48
@thekidnamedkd
thekidnamedkd requested a review from a team as a code owner July 1, 2026 21:29
@linear-code

linear-code Bot commented Jul 1, 2026

Copy link
Copy Markdown

APP-967

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-7asc08j6n-aragon-app.vercel.app
Suite smoke
Playwright result ❌ failed
Summary 66 passed, 4 flaky, 9 failed, 1 skipped
HTML report View report
GitHub job ✅ completed

View run #4399

Base automatically changed from app-954-build-ui-for-permission-page to main July 2, 2026 15:59
@thekidnamedkd

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #1238.

APP-967 became a duplicate once the permissions graph work moved under APP-942 and the backend relationship payload became the real source of data. #1238 carries forward the useful graph work from this PR, ports it into the monorepo/current app shape, removes the preview/mock path, and finishes the view against real permissions data.

Preview validation path carried into the replacement PR:

/dao/citrea-mainnet/0xA941b1C1D9aDC88C9241aA3ACA59E8B8f0386419/settings/permissions

Use ?permissionsview=graph for the graph view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants