Skip to content

feat(APP-1057): Enable ActionComposer outside the DAO context - #1273

Open
milosh86 wants to merge 4 commits into
mainfrom
app-1057-enable-actioncomposer-to-work-outside-of-a-dao-context
Open

feat(APP-1057): Enable ActionComposer outside the DAO context#1273
milosh86 wants to merge 4 commits into
mainfrom
app-1057-enable-actioncomposer-to-work-outside-of-a-dao-context

Conversation

@milosh86

@milosh86 milosh86 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Description

Enables ActionComposer and ProposalActionsEditor to run outside of a DAO context by making daoId optional and adding a network prop as a fallback (either one must be set). This lets the composer be used in flows where no DAO exists yet, offering only network-scoped and decoded actions instead of DAO-specific plugin/permission actions.

Key changes:

  • ActionComposer / ActionComposerInput / ProposalActionsEditor: daoId is now optional; DAO query is skipped when absent; WalletConnect import stays DAO-only.
  • actionComposerUtils: native DAO-specific groups (transfer, metadata update) are skipped when no DAO is resolved.
  • proposalActionsImportExportUtils.decodeActions: now takes network directly instead of deriving it from a required dao; without a DAO, decoded actions are normalized to the generic Unknown type.
  • smartContractService: decode-batch endpoint moved from /v2/contract/:network/:address/decode-batch to /v3/contract/:network/decode-batch, with the DAO address now an optional from query param instead of a URL param.
  • Added invariant checks on action Create/Details views (CreateProposal, Execute, TransferAsset, Multisig Add/Remove Members/Update Settings, GaugeRegistrar Unregister, GaugeVoter Activate/Deactivate, CapitalDistributor End/Pause/Resume Campaign) since these still resolve DAO data from action.daoId and only support DAO-context actions.

Related: APP-1057

Type of Change

  • Major: Breaking change (change that would cause existing functionality to not work as expected)
  • Minor: Feature (non-breaking change which adds new functionality)
  • Patch: Enhancement (non-breaking change to an existing feature)
  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

Stack created with GitHub Stacks CLIGive Feedback 💬

@linear-code

linear-code Bot commented Jul 31, 2026

Copy link
Copy Markdown

APP-1057

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-icrxb5w51-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 82 passed
HTML report View report
GitHub job ✅ completed

View run #4800

@milosh86
milosh86 marked this pull request as ready for review August 3, 2026 16:42
@milosh86
milosh86 requested a review from a team as a code owner August 3, 2026 16:42
Base automatically changed from app-1030-implement-crosschaincontroller-plugin-basic-action to main August 3, 2026 16:44
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
milosh86 force-pushed the app-1057-enable-actioncomposer-to-work-outside-of-a-dao-context branch from bd2e65e to 2950bca Compare August 3, 2026 16:54

@thekidnamedkd thekidnamedkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants