feat: canonical skills system with auto-sync to agent discovery roots - #1275
Open
thekidnamedkd wants to merge 6 commits into
Open
feat: canonical skills system with auto-sync to agent discovery roots#1275thekidnamedkd wants to merge 6 commits into
thekidnamedkd wants to merge 6 commits into
Conversation
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
1 task
…x docs - sync-skills.mjs: replace `-a codex/cursor/gemini-cli` (all resolve to the same universal .agents/skills store, causing 3x clean+recopy) with `-a universal -a claude-code`, so each generated root is written once. - sync-skills.mjs: CI skip now treats any truthy CI except '0'/'false' as CI, not only '1'/'true'. - sync-skills.mjs: correct the README.md-skip comment — the pinned CLI (1.5.20) excludes only metadata.json, not README.md. - .gitignore: drop .codex/skills, .cursor/skills, .gemini/skills; the pinned CLI never creates them (those agents map to .agents/skills). - skills/README.md: accurate install-target description + explicit note that node_modules-provided skills are not auto-authorized (experimental_sync is deliberately unused).
…omposition - Preserve lower-layer approvals with `gh stack rebase --upstack --no-trunk`; a full trunk rebase rewrites unchanged lower layers' SHAs and dismisses their reviews. - Verify shared-file diffs (en.json/generated registries) against base before pushing; a rebase/re-apply can silently drop unrelated keys.
thekidnamedkd
force-pushed
the
skills-refactor
branch
from
August 5, 2026 16:11
e98e3d1 to
8803702
Compare
Review bottom-up (1->N), merge once from the top PR. Document the bottom-by-bottom merge trap (each bottom merge rebases the layer above -> dismiss-stale-reviews wipes its approval) and the web merge button's misleading label; prefer gh stack merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Establishes one source of truth for repository skills under
skills/with automatic synchronization to project-level agent discovery roots onpnpm install. Supports Codex, Claude Code, Cursor, and Gemini CLI via the pinnedskills@1.5.20CLI.What changed:
skills/tree withskills/shared/(committed, repo-wide) andskills/local/(private, gitignored) catalogs..mdfiles (.agents/shared/skills/rules/*.md) to properSKILL.mddirectories (skills/shared/rules/<name>/SKILL.md), preserving git rename history.scripts/sync-skills.mjs— cross-platform sync wrapper: discovers, validates frontmatter, rejects duplicates, installs via--copy --yes --full-depth, validates generated filesystem independently, reconciles stale skills, skips on CI/SKIP_SKILLS_SYNC/missing CLI.package.json—skills@1.5.20exact devDep;skills:sync,test:skills,postinstallscripts..gitignore— generated roots (.agents/skills/,.claude/skills/,.codex/skills/,.cursor/skills/,.gemini/skills/) +skills-lock.json..agents/shared/hooks/inject-rules.mjs) repointed toskills/shared/rules/;collectRulesnow discovers<name>/SKILL.mddirectories instead of flat.md.scripts/sync-skills.test.mjs).SKILL_MANIFEST.json(pointed at a different repo) removed.Type of Change
Developer Checklist:
Review Checklist: