feat(APP-1003): Permission entity domain types, generators, and sentinels (1/5) - #1283
Open
thekidnamedkd wants to merge 7 commits into
Open
feat(APP-1003): Permission entity domain types, generators, and sentinels (1/5)#1283thekidnamedkd wants to merge 7 commits into
thekidnamedkd wants to merge 7 commits into
Conversation
thekidnamedkd
changed the title
|
🚀 Preview Deployment: View Here |
thekidnamedkd
changed the title
thekidnamedkd
changed the title
|
E2E results (preview) Smoke
|
thekidnamedkd
changed the title
thekidnamedkd
marked this pull request as ready for review
August 3, 2026 10:28
thekidnamedkd
changed the title
milosh86
reviewed
Aug 3, 2026
milosh86
left a comment
milosh86
left a comment
Contributor
There was a problem hiding this comment.
Left a couple of comments, looks good overall!
| "@aragon/app": none | ||
| --- | ||
|
|
||
| Internal layer of the APP-1003 permissions viewer stack — no user-facing changes. |
Contributor
There was a problem hiding this comment.
do we need changeset in this case? Just use empty changeset?
Contributor
Author
There was a problem hiding this comment.
'None' type skips as well. I didn't know about it either.
Contributor
There was a problem hiding this comment.
cool, didn't know about none
thekidnamedkd
force-pushed
the
stack/app-1003-01-domain
branch
from
August 4, 2026 13:22
6515135 to
52ef6aa
Compare
thekidnamedkd
force-pushed
the
stack/app-1003-01-domain
branch
from
August 4, 2026 17:35
52ef6aa to
7e2ed48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bottom layer of the APP-1003 permissions viewer stack (#1283–#1287). Adds shared domain types for permission entities (
PermissionEntityBrandId,PermissionEntityLayer,PermissionEntityStatus,PermissionEntityRole), generators (generateDaoPermission,generatePermissionEntityRef),permissionNameUtils, and the OSx sentinel constants (ANY_ADDR,ALLOW_FLAG). Inert — no UI or behavior changes.Type of Change
Developer Checklist:
Review Checklist: