Skip to content

feat(APP-1003): Permission data pipeline with two-toggle row filtering (2/5) - #1284

Open
thekidnamedkd wants to merge 7 commits into
stack/app-1003-01-domainfrom
stack/app-1003-02-data
Open

feat(APP-1003): Permission data pipeline with two-toggle row filtering (2/5)#1284
thekidnamedkd wants to merge 7 commits into
stack/app-1003-01-domainfrom
stack/app-1003-02-data

Conversation

@thekidnamedkd

@thekidnamedkd thekidnamedkd commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

Layer 2 of the APP-1003 permissions viewer stack. Adds the permissions fetch composition hook (usePermissionsData), the two-toggle row filter (filterPermissionRowsisDaoGrantedPermission + rowTargetsSubplugin), condition/entity resolvers, the graph builder (buildPermissionGraph), and removes the preview-era mock constants. Inert until the UI layers land.

Type of Change

  • Minor: Feature (non-breaking change which adds new functionality)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github's UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Confirmed that changes follow the code style guidelines of this project

@linear-code

linear-code Bot commented Aug 3, 2026

Copy link
Copy Markdown

APP-1003

@thekidnamedkd thekidnamedkd changed the title feat(APP-1003): Add permission data pipeline with two-toggle row filtering feat(APP-1003): Permission data pipeline with two-toggle row filtering (2/5) Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@thekidnamedkd thekidnamedkd changed the title feat(APP-1003): Permission data pipeline with two-toggle row filtering (2/5) issue(APP-1003): Permission data pipeline with two-toggle row filtering (2/5) Aug 3, 2026
@thekidnamedkd thekidnamedkd changed the title issue(APP-1003): Permission data pipeline with two-toggle row filtering (2/5) issue(APP-1003): Permission data pipeline with two-toggle row filtering (2/6) Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-9vi4rltbn-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 82 passed
HTML report View report
GitHub job ✅ completed

View run #4819

@thekidnamedkd
thekidnamedkd force-pushed the stack/app-1003-02-data branch from bc5b35d to 8d14d0c Compare August 3, 2026 09:46
@thekidnamedkd
thekidnamedkd force-pushed the stack/app-1003-02-data branch from 8d14d0c to 86c2440 Compare August 3, 2026 09:56
@thekidnamedkd thekidnamedkd changed the title issue(APP-1003): Permission data pipeline with two-toggle row filtering (2/6) issue(APP-1003): Permission data pipeline with two-toggle row filtering (2/5) Aug 3, 2026
@thekidnamedkd
thekidnamedkd marked this pull request as ready for review August 3, 2026 10:28
@thekidnamedkd
thekidnamedkd requested a review from a team as a code owner August 3, 2026 10:29
@thekidnamedkd thekidnamedkd changed the title issue(APP-1003): Permission data pipeline with two-toggle row filtering (2/5) feat(APP-1003): Permission data pipeline with two-toggle row filtering (2/5) Aug 3, 2026
milosh86
milosh86 previously approved these changes Aug 4, 2026

@milosh86 milosh86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍


const linkedAccounts = dao.linkedAccounts ?? [];
const showLinkedAccounts =
isEnabled('linkedAccount') && linkedAccounts.length > 0;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this "legacy" flag now as we fully implemented the feature?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but yeah, that's another question if we want to remove it or not.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants