Skip to content

feat(APP-1003): Responsive permissions list with condition slots (3/5) - #1285

Open
thekidnamedkd wants to merge 9 commits into
stack/app-1003-02-datafrom
stack/app-1003-03-list
Open

feat(APP-1003): Responsive permissions list with condition slots (3/5)#1285
thekidnamedkd wants to merge 9 commits into
stack/app-1003-02-datafrom
stack/app-1003-03-list

Conversation

@thekidnamedkd

@thekidnamedkd thekidnamedkd commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

Layer 3 of the APP-1003 permissions viewer stack. Adds the list components, condition slots (voting-power, execute-selector, membership, unrecognized, no-condition), entity icons, info tooltip, condition registry, the slot id rename (SETTINGS_PERMISSION_CONDITION), all locale keys, and removes the generated slot-docs system (generator + workflow + docs files, replaced with a pointer to the source enums in overview.md). The page renders list-only; the graph view arrives in L4.

Type of Change

  • Minor: Feature (non-breaking change which adds new functionality)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github's UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Confirmed that changes follow the code style guidelines of this project

@linear-code

linear-code Bot commented Aug 3, 2026

Copy link
Copy Markdown

APP-1003

@thekidnamedkd thekidnamedkd changed the title feat(APP-1003): Add responsive permissions list with condition slots feat(APP-1003): Responsive permissions list with condition slots (3/5) Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@thekidnamedkd thekidnamedkd changed the title feat(APP-1003): Responsive permissions list with condition slots (3/5) issue(APP-1003): Responsive permissions list with condition slots (3/5) Aug 3, 2026
@thekidnamedkd thekidnamedkd changed the title issue(APP-1003): Responsive permissions list with condition slots (3/5) issue(APP-1003): Responsive permissions list with condition slots (3/6) Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-6693mx2y9-aragon-app.vercel.app
Suite smoke
Playwright result ❌ failed
Summary 80 passed, 2 failed
HTML report View report
GitHub job ✅ completed

View run #4831

@thekidnamedkd
thekidnamedkd force-pushed the stack/app-1003-03-list branch from 2702f46 to 7ea7ed2 Compare August 3, 2026 09:46
@thekidnamedkd
thekidnamedkd force-pushed the stack/app-1003-03-list branch from 7ea7ed2 to ac3912c Compare August 3, 2026 09:56
@thekidnamedkd thekidnamedkd changed the title issue(APP-1003): Responsive permissions list with condition slots (3/6) issue(APP-1003): Responsive permissions list with condition slots (3/5) Aug 3, 2026
@thekidnamedkd
thekidnamedkd marked this pull request as ready for review August 3, 2026 10:29
@thekidnamedkd
thekidnamedkd requested a review from a team as a code owner August 3, 2026 10:29
@thekidnamedkd thekidnamedkd changed the title issue(APP-1003): Responsive permissions list with condition slots (3/5) feat(APP-1003): Responsive permissions list with condition slots (3/5) Aug 3, 2026
@thekidnamedkd
thekidnamedkd force-pushed the stack/app-1003-03-list branch from 12c029d to 7f156e5 Compare August 4, 2026 11:35
@thekidnamedkd
thekidnamedkd force-pushed the stack/app-1003-03-list branch from 7f156e5 to 4e9da77 Compare August 4, 2026 13:22

@milosh86 milosh86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean, I only left one comment regarding suspicious translation file edits which does not seem related to this PR. Please double check.

Comment thread apps/app/src/assets/locales/en.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants