fix: the dependency report is a probe too - #82
Merged
Merged
Conversation
It has no reader other than a monitor, and a degraded dependency already writes its own WARNING line naming what fell over, so the access entry adds nothing but volume once anything starts polling it. That WARNING is now the thing the tests hold onto, at both levels, because suppressing the access line makes it the only trace left. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EQda9NZvkbStEeNU54Tqgh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #81, which landed while this was still being written.
#81 stopped access-logging
/health-check/. This does the same for/health-check/dependencies: it has no reader other than a monitor, and nothing polls it today — but it would become exactly the same problem the moment something did, which is the point of putting a monitor on it at all.What makes that safe
A degraded dependency already writes its own line, naming what fell over:
{"message": "dependency check degraded", "degraded": ["object_storage"], "level": "WARNING", "logger": "service:health"}Suppressing the access entry makes that WARNING the only trace, so it is now what the tests hold onto rather than an incidental detail:
Verification
🤖 Generated with Claude Code
https://claude.ai/code/session_01EQda9NZvkbStEeNU54Tqgh