Repository navigation
Conversation
Refactor I2C request handling to improve readability and efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72
This PR updates Module::read() to use the return value of requestFrom() directly.
Module::read() requests howmany + 1 bytes in total:
1 byte for the pinstrap address
howmany bytes for the requested module data
Previously, the function only checked whether at least howmany bytes were available, which did not account for the extra pinstrap address byte.
The updated code verifies that all howmany + 1 expected bytes were received before reading them. It also removes the unnecessary wait loop after requestFrom() and the extra receive-buffer clearing loop.
If fewer than howmany + 1 bytes are received, the function now returns false.