fix(cli): raise maxBuffer in e2e run helper#342
Merged
Conversation
spawnSync's default 1 MB maxBuffer kills the CLI process (status: null) once its output outgrows the buffer. The e2e review suite approves the shared build on every run, so 'review list' output has grown with each CI run and finally crossed the limit, breaking e2e-core on main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
e2e-coreis red onmainsince yesterday (last three CI runs):e2e/review.test.ts > lists reviews in JSON modefails withCommandErrorandstatus: null.Root cause:
spawnSyncin the e2erun()helper uses the default 1 MBmaxBuffer— when the child's output exceeds it, Node kills the process (status: null). The review e2e suite creates ~3 approved reviews on the shared build (#27748) on every run, across a 9-job matrix, so thereview list --jsonoutput has been growing since April and finally crossed 1 MB.This raises
maxBufferto 128 MB with a comment explaining why.Worth considering separately: pruning the reviews on build 27748 (or pointing the suite at a fresh build periodically), since the output — and test duration — will keep growing forever otherwise.
Type of changes
bugChecklist
🤖 Generated with Claude Code