Skip to content

fix: format SECURITY.md so dprint passes - #272

Closed
gringokiwi wants to merge 1 commit into
masterfrom
fix/security-md-formatting
Closed

gringokiwi wants to merge 1 commit into
masterfrom
fix/security-md-formatting

Conversation

@gringokiwi

@gringokiwi gringokiwi commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

The formatting-dprint check has been failing on master since SECURITY.md landed in #266, so every open PR inherits a red check that has nothing to do with its own changes. I hit it on #268 and #270 and traced it back here.

Confirmed on a clean checkout of master:

$ dprint check --list-different
/Users/…/rust-sdk/SECURITY.md

One file, and it is not one that recent PRs touch.

The change

Whitespace only, produced by dprint fmt. The markdown plugin pads table columns to a common width; the table as committed does not. No content, no links, and no fingerprints are altered — the diff is 4 lines, all padding.

Verification

$ dprint check
# clean

Worth merging ahead of other open PRs so their checks reflect their own diffs.

Summary by CodeRabbit

  • Documentation
    • Improved the formatting and alignment of the PGP key table for easier reading.
    • Kept all listed names, URLs, and fingerprints unchanged.

The formatting-dprint job has been failing on master since SECURITY.md
landed in #266. Its table columns are not padded the way dprint's
markdown plugin wants, so every open PR inherits a red check that has
nothing to do with its own changes.

Whitespace only, produced by dprint fmt. No content changes.
@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c4df0dc-0541-4a37-ac9d-7dd16c455b8e

📥 Commits

Reviewing files that changed from the base of the PR and between 59818f8 and c40d832.

📒 Files selected for processing (1)
  • SECURITY.md

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


Walkthrough

The pull request reformats the security contact PGP key table in SECURITY.md. Names, URLs, and fingerprints remain unchanged.

Changes

Security documentation

Layer / File(s) Summary
PGP key table formatting
SECURITY.md
The table columns and separators are aligned consistently. The listed entries remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c40d8

This is a localized formatting-only change with no documented behavior or product impact, so it is merge-ready after normal checks and review with no actionable merge-blocking risk remaining.

Suggested reviewers: luckysori

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the formatting change to SECURITY.md and the dprint check objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/security-md-formatting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gringokiwi

Copy link
Copy Markdown
Contributor Author

fixed 1407ed2

@gringokiwi gringokiwi closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant