Skip to content

Fix structured inline arrays with zero-length dimensions failing to roundtrip#2083

Merged
sydduckworth merged 4 commits into
asdf-format:mainfrom
sydduckworth:fix-zero-dim-structured-array
Jun 25, 2026
Merged

Fix structured inline arrays with zero-length dimensions failing to roundtrip#2083
sydduckworth merged 4 commits into
asdf-format:mainfrom
sydduckworth:fix-zero-dim-structured-array

Conversation

@sydduckworth

Copy link
Copy Markdown
Member

Description

  • Fixed structured inline arrays with zero-length dimensions failing to roundtrip correctly
  • Added new test cases to test_empty_inline_array_roundtrip to test structured arrays in addition to scalar dtypes

Closes #2074

AI Disclosure

No AI tools used

Tasks

  • run prek on your machine
  • run pytest on your machine
  • Does this PR add new features and / or change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update relevant docstrings and / or docs/ page
    • for any new features, add unit tests
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: bug fix
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@sydduckworth sydduckworth marked this pull request as ready for review June 24, 2026 19:54
@sydduckworth sydduckworth requested a review from a team as a code owner June 24, 2026 19:54
@sydduckworth sydduckworth requested a review from braingram June 24, 2026 19:54
@sydduckworth sydduckworth merged commit 9eb9075 into asdf-format:main Jun 25, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0-length structured array fails to roundtrip inline

2 participants