docs: guard against NULL history.entries in README example#199
Closed
SAY-5 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Collaborator
|
@SAY-5 Thanks for this. I'm sorry you had to take the time -- I already started a broader update to this example code which also includes this fix. Your PR reminded me that I haven't finished that yet. Let me see where I left off.. |
Collaborator
|
Superseded by #201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #196. The cube example does
meta->history.entries[0]directly, butentriesis NULL when the file has no history (it only gets allocated when the history mapping has an "entries" key, see src/core/asdf.c), so the example segfaults on any file without a history entry. Added a NULL check onentriesitself before indexing it.