Disable composite R2R + .NET 11 benchmark scenarios#2180
Merged
DrewScoggins merged 1 commit intoJun 9, 2026
Merged
Conversation
LoopedBard3
approved these changes
Jun 9, 2026
LoopedBard3
left a comment
LoopedBard3
left a comment
Contributor
There was a problem hiding this comment.
Looks good, feel free to merge as long as we have an issue tracking reenablement. Could just add this as another PR to revert as part of #2178.
There was a problem hiding this comment.
Pull request overview
This PR temporarily disables composite ReadyToRun (R2R) benchmark configurations that hang/crash crossgen2 on certain .NET 11 preview SDKs, preventing crank-agent build timeouts until the runtime fix (dotnet/runtime#129053) flows into the SDK used by benchmark agents.
Changes:
- Commented out Single-file, Trimmed, and composite R2R modes in the single-file benchmark pipeline template.
- Commented out crossgen2 composite profiles (including avx2) in the crossgen2 benchmark pipeline template.
- Disabled (via
condition: 'false') the three Goldilocks “Trim R2R SingleFile” CoreCLR jobs in the NativeAOT benchmark pipeline template.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/singlefile-scenarios.yml | Removes composite/R2R-affected modes from the single-file benchmark job matrix (with TODO notes for re-enabling). |
| build/crossgen2-scenarios.yml | Disables composite crossgen2 profiles to avoid known hangs/crashes on affected .NET 11 SDKs. |
| build/nativeaot-scenarios.yml | Turns off the Goldilocks CoreCLR “Trim R2R SingleFile” jobs by setting their conditions to false. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DrewScoggins
force-pushed
the
anscoggi/disable-r2r-composite-async-runtime129053
branch
from
75fd83f to
7442e38
Compare
DrewScoggins
force-pushed
the
anscoggi/disable-r2r-composite-async-runtime129053
branch
from
7442e38 to
2486ce7
Compare
These scenarios all hang/crash in crossgen2 with IndexOutOfRangeException on .NET 11 preview SDKs that predate dotnet/runtime#129053 ("Fix composite R2R token corruption for devirtualized async-variant callees", merged 2026-06-06). The repro hits Kestrel's Http1ChunkedEncodingMessageBody.PumpAsync during composite R2R compilation; crossgen2 then fails to terminate, causing the crank-agent 10-minute build timeout we saw on 2026-06-08. build/singlefile-scenarios.yml: add per-mode `condition` field (threaded into the crank job condition) and set 'false' for Single-file, Trimmed, R2RComposite-Windows, R2RComposite-Linux. build/crossgen2-scenarios.yml: enrich the existing disable note on "CG2 composite" / "CG2 composite avx2" (already disabled by aspnet#2177) with a pointer to the upstream runtime fix. build/nativeaot-scenarios.yml: set condition to 'false' on the three Goldilocks "Trim R2R SingleFile" jobs (Stage1, Stage2, gRPC Stage1). Self-contained, AOT, non-composite R2R, and all NativeAOT scenarios remain enabled - the bug is composite-R2R-specific. Re-enable once the runtime fix flows into the .NET 11 SDK consumed by the benchmark agents. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DrewScoggins
force-pushed
the
anscoggi/disable-r2r-composite-async-runtime129053
branch
from
2486ce7 to
f1436be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These scenarios all hang/crash in crossgen2 with IndexOutOfRangeException on .NET 11 preview SDKs that predate dotnet/runtime#129053 ("Fix composite R2R token corruption for devirtualized async-variant callees", merged 2026-06-06). The repro hits Kestrel's Http1ChunkedEncodingMessageBody.PumpAsync during composite R2R compilation; crossgen2 then fails to terminate, causing the crank-agent 10-minute build timeout we saw on 2026-06-08.
build/singlefile-scenarios.yml: comment out Single-file, Trimmed,
R2RComposite-Windows, R2RComposite-Linux modes.
build/crossgen2-scenarios.yml: comment out "CG2 composite" and
"CG2 composite avx2" profiles.
build/nativeaot-scenarios.yml: set condition to 'false' on the three
Goldilocks "Trim R2R SingleFile" jobs (Stage1, Stage2, gRPC Stage1).
Self-contained, AOT, non-composite R2R, and all NativeAOT scenarios remain enabled - the bug is composite-R2R-specific.
Re-enable once the runtime fix flows into the .NET 11 SDK consumed by the benchmark agents.