ci: add GitHub Actions workflow for fmt, lint, build, and test - #7
Merged
Merged
Conversation
Adds a single CI workflow with two jobs: one for `cargo +nightly fmt` and `cargo clippy`, and one for `cargo build` and `cargo test`. Both jobs install protoc (required by `daccord-demo`'s `tonic-build`) and use the standard rust-cache to keep runs fast.
Required for the new CI fmt-check job to pass — current nightly rustfmt collapses several multi-line signatures and string-into calls onto a single line, and reorders the cfg-gated `redb` re-exports.
The previous proto change added `start_index` and made `limit` optional,
but the CLI binary and chaos-harness test still constructed an empty
`GetDecisionsRequest {}`, breaking the build. Set `start_index = 0`
and `limit = None` to preserve "fetch from the beginning, server-default
limit" behavior.
assafvayner
marked this pull request as ready for review
May 8, 2026 06:12
…tes" Revert "chore(demo-proto): make GetDecisionsRequest.limit optional" These were not part of the CI-workflow PR. Reverting both keeps this branch focused on adding `.github/workflows/ci.yml` and the rustfmt fixes required for it to pass. The proto change (and its dependent demo updates) can land in a separate PR. This reverts commits d3b3322 and 7db5afb.
`proposals_from_different_nodes` reliably fails on GitHub-hosted runners with the previous 5s per-decision timeout — three concurrent proposers on a 3-node cluster can take longer than 5s to converge under runner load even when the algorithm is healthy. Locally tests still complete in well under 5s, so the bump only affects the slow-runner case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlwith two jobs:cargo +nightly fmt --all -- --checkandcargo clippy --workspace --all-targets --all-features -- -D warningscargo build --workspace --all-targets --all-featuresandcargo test --workspace --all-featuresmainand on all pull requests, with concurrency cancellation for non-mainrefs.protoc(required bydaccord-demo'stonic-build) and usesSwatinem/rust-cachewith a shared key across jobs.--all-featuresactivatesduckdb-bundled, so theduckdbsystem library is not required on runners.Test plan
multi-paxos,redb,duckdb)