Skip to content

asterisk_testsuite: Fixed Replaced SIPp -mp with -min_rtp_port PR25#141

Open
AlexisHadj wants to merge 1 commit into
asterisk:masterfrom
AlexisHadj:pr25-fresh
Open

asterisk_testsuite: Fixed Replaced SIPp -mp with -min_rtp_port PR25#141
AlexisHadj wants to merge 1 commit into
asterisk:masterfrom
AlexisHadj:pr25-fresh

Conversation

@AlexisHadj

Copy link
Copy Markdown
Contributor

Added the following requirements recommended in PR 25:

  1. Reverted the yaml files to specifying -mp
  2. Check the version to see which option -mp or -min_rtp_port is supported by that version and set the default to it.
  3. Check the arguments passed by the iterator and replace occurrences of those options with the ones valid for the sipp version.

Added the following requirements recommended in PR 25:
1. Reverted the yaml files to specifying -mp
2. Check the version to see which option -mp or -min_rtp_port is supported by that version and set the default to it.
3. Check the arguments passed by the iterator and replace occurrences of those options with the ones valid for the sipp version.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Checklist Complete

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Workflow Check completed successfully

@AlexisHadj

AlexisHadj commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

cherry-pick-to: 20
cherry-pick-to: 21
cherry-pick-to: 22
cherry-pick-to: 23
cherry-pick-to: certified/20.7
cherry-pick-to: certified/22.8

@gtjoseph
gtjoseph dismissed github-actions[bot]’s stale review June 9, 2026 13:35

Pull Request Checklist Complete

@gtjoseph

gtjoseph commented Jun 9, 2026

Copy link
Copy Markdown
Member

So this PR replaces #25 right? I can close that PR?

@AlexisHadj

Copy link
Copy Markdown
Contributor Author

So this PR replaces #25 right? I can close that PR?

I believe you can close it

@github-actions github-actions Bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-passed Cherry-Pick checks passed and removed cherry-pick-test cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Jul 15, 2026
@github-actions

Copy link
Copy Markdown

Workflow CPCheck completed successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants