Fix intuitive propagation behavior#52
Open
zach-capalbo wants to merge 5 commits into
Open
Conversation
- Add small threshold to begin dragging - Don't propagate clicks to scrolled element after movement has reached threshold - Useful if you are scrolling something with lots of links or buttons in it - Don't propagate `mousedown` events - Useful if you have `.dragscroll`s embedded in other `.dragscroll`s
|
this works perfectly for me. |
|
This worked really well as a fix on a sliding navigation bar, where navigation clicks were being incorrectly detected as drags in some cases. |
|
+1 for the works really well! |
|
Worked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mousedownevents.dragscrolls embedded in other.dragscrollsThese changes break current behavior, and add a few more bytes, but it makes the behavior a lot more intuitive to me. Creating the pull request in case it seems more intuitive to anyone else.