Skip to content

Fix #813 - Address Code Issues - #2437

Closed
Vanguard-Sidd wants to merge 12 commits into
athensresearch:mainfrom
Vanguard-Sidd:vanguard/b-c4a9
Closed

Vanguard-Sidd wants to merge 12 commits into
athensresearch:mainfrom
Vanguard-Sidd:vanguard/b-c4a9

Conversation

@Vanguard-Sidd

Copy link
Copy Markdown

Approved Technical Plan – Implement “Find on Page” (Ctrl/Cmd + F) for the Electron version of Element‑Web


1. High‑level Overview

Step Action Why it matters
1️⃣ Audit existing shortcut/command handling – locate the file(s) that register global shortcuts. Guarantees we hook into the correct place and avoid duplicate logic.
2️⃣ Create a FindDialog UI component – overlay with input, options (match case, whole word, regex), navigation buttons, and close control. Provides the user‑visible control for the search operation.
3️⃣ Expose an IPC channel (find-in-page) that forwards the request to Electron’s webContents.findInPage. The renderer cannot call webContents directly; the main process must mediate.
4️⃣ Implement the IPC handler in the Electron main process (boot file). Performs the actual search on the page and forwards results back to the renderer.
5️⃣ **Listen for `foun

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


vanguard-delivery seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Vanguard-Sidd

Copy link
Copy Markdown
Author

Thank you for the clarification. I have signed the Contributor License Agreement and ensured that the email address used for the commits is associated with my GitHub account. The CLA status should now be updated, and the PR is ready for review. Please let me know if any further changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants