feat: types.{Header,BlockBody}Hooks.PostRPCMarshal methods#285
Merged
Conversation
ARR4N
force-pushed
the
arr4n/rpc-hooks-for-types
branch
from
53dc6d0 to
a6c1a92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
RPC support of
types.Headerandtypes.Blockextra payloads.How this works
Adds
PostRPCMarshal()methods totypes.HeaderHooksandtypes.BlockBodyHooks, which are called by the respectethapifunctions to allow for mutation of the output before being returned by the RPC endpoint.How this was tested
Integration test of new hooks with
internal/ethapi/BlockChainAPI.