Repository navigation
Conversation
Add the 64-control catalog, disposition-aware scoring, Connect-side Agentic CX Designer checks, and hardened evidence handling. Extend the existing Cloudscape report with report-wide instance scope, clickable metric and chart drill-downs, responsive evidence, complete print output, and a Git-independent bundle freshness check. Regenerate the public sample report, screenshots, architecture, and user documentation.
Describe the self-contained React and Cloudscape report accurately and remove stale Chart.js and Font Awesome CDN guidance. Add a regression check so public documentation cannot reintroduce those dependencies.
Backfill missing selected-control outcomes, tighten Journey coverage and AWS evidence handling, and preserve stable ASFF identity. Restore UTC output, complete report printing, instance scoping, documentation, and regenerated sample artifacts.
- Allow intentional severity escalation for the three quota controls (res-quota-config-001, res-quota-headroom-001, res-quota-growth-001) via a dynamic_severity catalog flag so a near-quota instance no longer aborts the assessment with ValueError in finding validation. - Storage encryption (sec-storage-001): Kinesis stream/Firehose delivery no longer forces SKIPPED (agent events can only stream to Kinesis); a single failed resource-type read no longer discards evaluated types. SKIPPED is reserved for runs where nothing could be evaluated, and PASS/FAIL descriptions carry explicit scope notes. - Honour top-level skip_flow_analysis during check registration so the journey controls are not selected-but-never-executed and backfilled as synthetic ERROR outcomes. - Deduplicate _error_code into checks/base.py. - Build the ACXD flow inventory once per instance (identity-keyed weakref cache) instead of re-parsing every flow in each of the three Agentic CX checks. - Update AGENTS.md: HTML report shell uses @@name@@ placeholder substitution, not Jinja. Adds regression tests for each fix; suite: 1204 passed, 3 skipped.
The check declared Informational while its control catalog entry (cost-usage-metrics-001) is Manual Review. Declare MANUAL_REVIEW and update the disposition test accordingly.
register_check now copies catalog disposition and methodology onto the check, so final validation no longer rejects findings from checks that bypassed hydrate_base_checks.
…atalog _canonical_missing_outcome assumed every registered control ID exists in the built-in catalog and raised KeyError for custom checks. Fall back to the registered check's metadata.
Standalone checks registered without a catalog were validated against global catalog metadata sharing their ID, raising ValueError for valid findings.
agasthik
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Public branch scope
This branch intentionally excludes changes to
.github/workflows/**,.kiro/**,.gitlab-ci.yml, internal presenter artifacts, internal reports, and local scanner state.