fix: preserve harness deployed state on early deploy errors#933
Merged
fix: preserve harness deployed state on early deploy errors#933
Conversation
Early error returns in HarnessDeployer (validation failure, read error, missing role ARN, delete failure) were not including the resultState, causing deployed harness entries to be wiped from deployed-state.json. On the next deploy, the missing state caused the deployer to attempt a create instead of update, resulting in a 409 "agent already exists" error.
avi-alpert
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HarnessDeployer.deploy()(validation failure, read error, missing role ARN, delete failure) were not includingstate: resultStatein the return valueactions.tsto seeharnessResult.stateasundefined, wiping the harness entries fromdeployed-state.jsonTest plan