Repository navigation
feat(ci): re-run the skill check on main and build the docs on PRs (4/4) - #129
Draft
miscreantmoogly wants to merge 2 commits into
Draft
miscreantmoogly wants to merge 2 commits into
miscreantmoogly wants to merge 2 commits into
Conversation
3 of 6 tasks
Contributor
|
Holding this one, and #125 likewise: @aadimch and @miscreantmoogly have each built the same check independently, and the two are not compatible as they stand — most pointedly, I have asked the two of you to agree on which set to keep. |
validate-skills-main runs the publishing check after each push to main, against the commit main pointed at before, so two pull requests that each passed on an older base but break the rules together are reported at once. build-docs runs mkdocs build --strict on every pull request with the same mkdocs-material pin as deploy-docs, so a change that would break the Pages site is caught before merge. It deploys nothing.
A pull request runs its own copy of every check, so without code owners it could edit a check, or its rule data, to pass. Takes effect once branch protection requires review from code owners.
miscreantmoogly
force-pushed
the
validate-skills/4-workflows
branch
from
October 9, 2026 17:35
d207d2e to
7e1d05d
Compare
miscreantmoogly
added this pull request to stack #134
October 9, 2026 20:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validate-skills-main.ymlre-runs the check after every push tomain, against the commitmainpointed at before the push. Two PRs that each passed on an older base can break the rules together, for example by bumping one skill to the same version. This reports it at once.build-docs.ymlrunsmkdocs build --stricton every PR, with the samemkdocs-materialpin asdeploy-docs.yml. Today a broken Pages build is found only after merge (fix(docs): unbreak the strict docs build on main #122). It builds only; it deploys nothing and doesn't change Pages..github/CODEOWNERSmakes@aws/tools-for-devops-agent-adminsthe owner of/.github/. A PR runs its own copy of every check, so without this it could edit a check, or its rule data, to pass.Type of change
Testing
mkdocs build --strictpasses locally withmkdocs-material==9.6.14.before, or a missing one after a force push) can only be exercised after merge.Requests for maintainers (after the stack merges)
validate-skills,build-docsand the existingscan-aws-identifiersto the required status checks formain.