Skip to content

feat(ci): re-run the skill check on main and build the docs on PRs (4/4) - #129

Draft
miscreantmoogly wants to merge 2 commits into
validate-skills/3-versionsfrom
validate-skills/4-workflows
Draft

miscreantmoogly wants to merge 2 commits into
validate-skills/3-versionsfrom
validate-skills/4-workflows

Conversation

@miscreantmoogly

@miscreantmoogly miscreantmoogly commented Oct 8, 2026 •

Copy link
Copy Markdown

Stacked PR 4 of 4. Based on #128; review and merge in order. This diff shows only this PR's changes.

Description

  • validate-skills-main.yml re-runs the check after every push to main, against the commit main pointed at before the push. Two PRs that each passed on an older base can break the rules together, for example by bumping one skill to the same version. This reports it at once.
  • build-docs.yml runs mkdocs build --strict on every PR, with the same mkdocs-material pin as deploy-docs.yml. Today a broken Pages build is found only after merge (fix(docs): unbreak the strict docs build on main #122). It builds only; it deploys nothing and doesn't change Pages.
  • .github/CODEOWNERS makes @aws/tools-for-devops-agent-admins the owner of /.github/. A PR runs its own copy of every check, so without this it could edit a check, or its rule data, to pass.

Type of change

  • Documentation or infrastructure change

Testing

  • mkdocs build --strict passes locally with mkdocs-material==9.6.14.
  • The workflow YAML parses.
  • The post-merge base fallback (an all-zero before, or a missing one after a force push) can only be exercised after merge.

Requests for maintainers (after the stack merges)

  1. Add validate-skills, build-docs and the existing scan-aws-identifiers to the required status checks for main.
  2. Turn on "Require review from Code Owners", so CODEOWNERS takes effect.
  3. Turn on "Require branches to be up to date before merging", or a merge queue.
  4. Turn on secret scanning with push protection, and dismissal of stale approvals.

@ams-thakkar

Copy link
Copy Markdown
Contributor

Holding this one, and #125 likewise: @aadimch and @miscreantmoogly have each built the same check independently, and the two are not compatible as they stand — most pointedly, metadata.deprecated is specified oppositely (quoted "true" here, unquoted true in #125), and each documents its own form in CONTRIBUTING.md.

I have asked the two of you to agree on which set to keep.

validate-skills-main runs the publishing check after each push to main,
against the commit main pointed at before, so two pull requests that each
passed on an older base but break the rules together are reported at once.

build-docs runs mkdocs build --strict on every pull request with the same
mkdocs-material pin as deploy-docs, so a change that would break the Pages
site is caught before merge. It deploys nothing.
A pull request runs its own copy of every check, so without code owners it
could edit a check, or its rule data, to pass. Takes effect once branch
protection requires review from code owners.
@miscreantmoogly
miscreantmoogly force-pushed the validate-skills/4-workflows branch from d207d2e to 7e1d05d Compare October 9, 2026 17:35
@miscreantmoogly
miscreantmoogly added this pull request to stack #134 October 9, 2026 20:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants