Conversation
4 tasks
apackeer
force-pushed
the
fix/config-filesystem-lock
branch
from
September 13, 2026 06:48
5b0c2e7 to
e65fea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #1107; the base is
fix/config-filesystem-lock.Config can now proceed when a compatible mounted filesystem rejects hard links. Transaction locking automatically falls back to an owner-stamped directory, while a local process gate serializes acquisition, recovery, execution, and release.
This removes the reported hard-link blocker. It is bounded compatibility support, not certification of arbitrary S3 filesystem drivers: the mount must still provide the file semantics required by AI-DLC.
Changes
.aidlc-transaction.lockas the destination lock path so existing file-lock owners remain protected.User experience
For a mount whose missing hard-link operation was the blocker, first-run config, refresh, and workflow writes can use directory locking without a new flag.
All cooperating processes must use one continuously running mount on one host, a common local temporary directory, and the same PID namespace. This is not a distributed lock across independent mounts or hosts.
The filesystem still supplies coherent identity/append behavior and atomic replacement/rename semantics. Successful probes cannot prove crash durability or atomicity. Mountpoint lacks operations needed for full workflows; s3fs implements rename through copy/delete and does not establish the full atomic-rename contract. Those limitations are documented explicitly, and this PR adds no copy/delete emulation of a failed rename.
Checklist
Test plan
bun scripts/package.tsbun scripts/package.ts --checkbun run typecheckbun run lintbash tests/run-tests.sh --debug -P 8 --unit --filter ...: 215 passed, 0 failed across installation/configuration (94), transaction filesystems and concurrency (43), first-run/installed-workflow behavior (41), and coverage registry (37).Tests disable hard links throughout all setup subprocesses and then exercise config, refresh, installed intent creation, state changes, and audit writes. They also cover multiprocess exclusion, interrupted-owner recovery, rollback, capability rejection without project changes, and local-gate release recovery.
Validation uses isolated filesystem fault injection around real file operations. No live S3 mount was exercised, and the reporting user's mount driver remains unknown.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.