fix: discover stage-level summary questions when units are skipped - #1110
Merged
Merged
Conversation
apackeer
requested review from
a team,
Kalindi-Dev,
harmjeff,
leandrodamascena,
raj-jain-aws,
scottschreckengaust and
spraja08
September 10, 2026 07:45
apackeer
force-pushed
the
fix/stage-level-summary-questions
branch
from
September 16, 2026 04:49
d7d75bf to
b020352
Compare
This was referenced Sep 16, 2026
apackeer
added a commit
that referenced
this pull request
Sep 17, 2026
* origin/main: fix: make compiled dispatch exhaustive over TOOLS so native review briefs route (#1070) (#1115) test: skip POSIX gate-sensor fixture on Windows (#1208) fix: make /aidlc compose scopes durable across an engine reinstall (#1159) fix: refuse orphaned positionals at intent-create instead of storing a truncated description (#1114) (#1195) fix: route compiled gate-sensor dispatch through the engine namespace (#1166) fix: name the accepted values in review-path refusals (#1082) (#1194) fix: discover stage-level summary questions when units are skipped (#1110) fix: keep a JSON-scalar gate reply instead of parsing it away (#1186) fix: resolve the zero-Unit code-generation location in the traceability sensor (#1179) fix(config): one quiet line for --show, and honest source options on a copy-channel refresh (#1185) test(t238): normalize walkFiles separators in the invocation-surface selector (#1184) fix(config): Kiro provides its own model access, so the provider section has nothing to ask (#1183) chore: prepare 2.9.0 release (#1181) feat!: classic scope v1 parity with scope-owned ceremony switches (#1151) fix: publish changed previews without a daily cap (#1178) fix: separate Bun copy and native installer runtimes (#1174) fix: publish next-patch previews nightly (#1169) fix: keep review bookkeeping out of the artifact, and out of the reviewer's findings (#1160) fix: measure the review budget against the engine's own ordinal, not the caller's (#1158)
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix false
SUMMARY_QUESTIONS_MISSINGrefusals when a workflow skips Units Generation and stores construction questions at stage level, as theinfrascope does.Summary-question discovery now follows the effective plan's artifact placement. Workflows that execute Units Generation continue to use each Unit's own questions and confirmation. Isolated stage reviews retain their own question placement even when the parent workflow skips Units Generation, while preserving the parent's confirmation and Change Control policy.
Regression coverage checks scope defaults, plan overrides, obsolete Unit directories, isolated review and completion, and missing, stale, rejected, or unauthorized confirmation evidence.
User experience
A user who answers construction questions, confirms the summary, and generates artifacts in the engine-selected directory can continue through the remaining stage checks. An isolated per-unit stage can also be reviewed without inheriting the parent workflow's artifact directory. Invalid confirmation evidence still blocks progress.
This restores the existing placement contract. It adds no commands, flags, or receipt-identity inputs and requires no configuration migration.
Validation
Checklist
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.