Skip to content

Fixes #5716 az_text_media_paragraph_behavior does not check field group existence#5719

Merged
joeparsons merged 1 commit into
mainfrom
issue/5716
Jun 24, 2026
Merged

Fixes #5716 az_text_media_paragraph_behavior does not check field group existence#5719
joeparsons merged 1 commit into
mainfrom
issue/5716

Conversation

@tadean

@tadean tadean commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

The az_text_media_paragraph_behavior plugin does not check if specific field groups exist before using them. This can cause PHP errors on sites that have diverged from Quickstart's configuration.

This PR checks if the field group structures exist before using them. The null-safe operator cannot be used here since the variables are used in a write context.

Related issues

#5716

How to test

  • Create page using text on media paragraphs
  • Verify content displays correctly
  • Visit /admin/structure/paragraphs_type/az_text_media/display
  • Delete one or more of the field groups group_az_column, group_az_title, or group_az_content
  • View the page content you created again
  • It may display unusually due to the missing field groups, but should not cause a whitescreen error

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@tadean tadean self-assigned this Jun 23, 2026
@tadean tadean requested a review from a team as a code owner June 23, 2026 20:59
@tadean tadean requested a review from a team as a code owner June 23, 2026 20:59
@tadean tadean added bug Something isn't working patch release Issues to be included in the next patch release backport-2.x Changes to be back-ported to the 2.x development branch labels Jun 23, 2026
@joeparsons joeparsons moved this from Todo to Needs review in 3.4.3 security patch release Jun 23, 2026

@djcelaya djcelaya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reproduced the error locally using the testing instructions on a vanilla build. I then repeated the steps on another build of this PR and no longer observed the WSOD.

@github-project-automation github-project-automation Bot moved this from Needs review to Ready to merge in 3.4.3 security patch release Jun 23, 2026
@joeparsons joeparsons merged commit 5f59005 into main Jun 24, 2026
31 of 33 checks passed
@joeparsons joeparsons deleted the issue/5716 branch June 24, 2026 17:02
@github-project-automation github-project-automation Bot moved this from Ready to merge to Done in 3.4.3 security patch release Jun 24, 2026
@joeparsons joeparsons moved this from Needs review to Done in 2.14.15 LTS security patch release Jun 24, 2026
joeparsons pushed a commit that referenced this pull request Jun 24, 2026
…up existence (2.x backport of #5719) (#5725)

(cherry picked from commit 5f59005)

Co-authored-by: tadean <51835841+tadean@users.noreply.github.com>
joeparsons pushed a commit that referenced this pull request Jun 24, 2026
…up existence (2.x backport of #5719) (#5725)

(cherry picked from commit 5f59005)

Co-authored-by: tadean <51835841+tadean@users.noreply.github.com>
(cherry picked from commit 872b4ea)
joeparsons pushed a commit that referenced this pull request Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-2.x Changes to be back-ported to the 2.x development branch bug Something isn't working patch release Issues to be included in the next patch release

Projects

Development

Successfully merging this pull request may close these issues.

AZTextWithMediaParagraphBehavior doesn't check for the existence of some field groups

3 participants