Skip to content

[chore] Map error for getting function#27

Merged
RogerKSI merged 12 commits into
masterfrom
mapping-error
Jun 2, 2026
Merged

[chore] Map error for getting function#27
RogerKSI merged 12 commits into
masterfrom
mapping-error

Conversation

@RogerKSI

@RogerKSI RogerKSI commented Jun 2, 2026

Copy link
Copy Markdown
Member

Fixed:

  • map error when getting function from instance

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI changed the title [chore] Map error for finding function [chore] Map error for getting function Jun 2, 2026
@RogerKSI RogerKSI requested review from satawatnack and taobun June 2, 2026 09:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to avoid a runtime panic when resolving the VM entry function from a Wasmer instance by turning the failure into a structured Error, and it also adjusts the VM crate’s dependency constraints and CI setup.

Changes:

  • Replace a unwrap() on instance.exports.get_function(...) with error mapping.
  • Add multiple direct dependencies with version ranges in owasm-vm (apparently to constrain transitive dependency resolution).
  • Pin CI Rust toolchain to 1.76 and bump actions/cache to v4.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
packages/vm/src/calls.rs Converts entry function resolution from panic-on-error to returning a VM Error.
packages/vm/Cargo.toml Adds dependency constraints / additional deps that affect the crate’s resolved dependency graph.
.github/workflows/ci.yaml Pins CI Rust toolchain version and updates the cache action version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/vm/src/calls.rs
Comment thread packages/vm/src/calls.rs
Comment thread packages/vm/Cargo.toml
Comment thread .github/workflows/ci.yaml
@RogerKSI RogerKSI merged commit 4f09e9e into master Jun 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants