Conversation
Fix broken relative and absolute $ref pointers across schema files: - CallbackAction, RequestAction: remove broken $ref to non-existent BecknAction - TransactionEndpoint: remove invalid allOf inheritance to BecknEndpoint - LineageEntry: update action $ref from BecknEndpoint to TransactionEndpoint - GroceryItem, HomeAndKitchenItem: remove invalid allOf inheritance to RetailCoreItem - SalesOfferPackage: update distributions $ref to CommunicationChannel - SafetyPolicy: update emergencyContact $ref to Contact - CodedValue: add missing schema.json for v2.1 referenced by CourseResourceAttributes Fixes beckn#56 Signed-off-by: Abhinav Prakash <abhinavprakash616@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken relative and absolute
$refpointers across schema definitions in the repository to ensure all referenced schema fragments and files resolve cleanly without 404 or missing file errors.Fixes #56
Changes
CallbackAction/v2.0&RequestAction/v2.0:$refpointers targeting non-existentBecknAction/v2.0schemas in bothattributes.yamlandschema.json.type: objectdeprecated stubs.TransactionEndpoint/v2.0&LineageEntry/v2.0:allOfinheritance pointing to non-existentBecknEndpoint/v2.0fromTransactionEndpoint/v2.0(attributes.yamlandschema.json).TransactionEndpoint/v2.0directly astype: stringwith standard endpoint enumeration.LineageEntry/v2.0actionproperty$refinattributes.yaml,schema.json, andREADME.mdto point toTransactionEndpoint/v2.0.GroceryItem/v2.0&HomeAndKitchenItem/v2.0:allOfinheritance pointing to deletedRetailCoreItem/v2.0fromattributes.yamlandschema.json.type: object.SalesOfferPackage/v2.0:distributionsproperty$refinattributes.yaml,schema.json, andREADME.mdto point to existingCommunicationChannel/v2.0instead of non-existentDistributionChannel/v2.0.SafetyPolicy/v2.0:emergencyContactproperty$refinattributes.yaml,schema.json, andREADME.mdto point to existingContact/v2.0instead of non-existentContactHandle/v2.0.CodedValue/v2.1&CourseResourceAttributes/v2.1:schema/CodedValue/v2.1/schema.jsonto satisfy the$reftargets inCourseResourceAttributes/v2.1/schema.json.Documentation & Changelog:
CHANGELOG.mdwith an unreleased patch record detailing the fixes.Verification
$refpointers across all YAML and JSON schemas.$referrors.