Update Credentials for new version boto3#20
Open
alexshenia wants to merge 1 commit into
Open
Conversation
Author
|
I will try to find in which version boto3 added |
2e14492 to
f2b9b24
Compare
Owner
|
Hm, I'd rather leave this without the new account id field, and just update line 50 to transfer the fields directly. Then I don't have to worry about whether people are using it with old versions of botocore or not. |
|
+1 |
f2b9b24 to
6c378bd
Compare
|
Thanks @alexshenia |
Author
|
@benkehoe is this version ok for you? |
|
I just came across this issue myself |
Author
|
@benkehoe just a reminder to check PR |
Author
|
@benkehoe can you take a look ? I updated to directly use fields to support old and new version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boto3 v.1.37 and above added new
account_idas parameter andread_only_credsnow returns alsoaccount_idso now it is 6 params instead of 5.
This PR will fix
Credentials.__new__() takes 5 positional arguments but 6 were given