Skip to content

Update Credentials for new version boto3#20

Open
alexshenia wants to merge 1 commit into
benkehoe:masterfrom
alexshenia:fix-credentials
Open

Update Credentials for new version boto3#20
alexshenia wants to merge 1 commit into
benkehoe:masterfrom
alexshenia:fix-credentials

Conversation

@alexshenia

@alexshenia alexshenia commented Apr 15, 2025

Copy link
Copy Markdown

boto3 v.1.37 and above added new account_id as parameter and read_only_creds now returns also account_id

so now it is 6 params instead of 5.

This PR will fix Credentials.__new__() takes 5 positional arguments but 6 were given

@alexshenia

Copy link
Copy Markdown
Author

I will try to find in which version boto3 added account_id and I will update version and pyproject.toml

@benkehoe

Copy link
Copy Markdown
Owner

Hm, I'd rather leave this without the new account id field, and just update line 50 to transfer the fields directly. Then I don't have to worry about whether people are using it with old versions of botocore or not.

@steve-ochoa

Copy link
Copy Markdown

+1

@steve-ochoa

Copy link
Copy Markdown

Thanks @alexshenia

@alexshenia

Copy link
Copy Markdown
Author

@benkehoe is this version ok for you?

@ericriff

Copy link
Copy Markdown

I just came across this issue myself
Any ETA on this PR + new release? Thanks!

@alexshenia

Copy link
Copy Markdown
Author

@benkehoe just a reminder to check PR

@alexshenia

Copy link
Copy Markdown
Author

@benkehoe can you take a look ? I updated to directly use fields to support old and new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants