update vllm version compatibility for disabling mm preprocessor args, add image support for HF datasets#66
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to how Hugging Face datasets—especially raw image files—are handled in the data processing pipeline, and enhances vLLM worker compatibility with different vLLM versions. The changes allow the system to correctly identify and process image shards, improve chunk/shard tracking, and ensure that only supported vLLM initialization parameters are passed to the engine, increasing robustness and flexibility.
Hugging Face dataset processing improvements:
vLLM worker compatibility and configuration:
mm_processor_cache_gb,mm_processor_cache_type,mm_shm_cache_max_object_size_mb) to configuration and ensured they are included only if present. [1] [2]Documentation updates:
README.mdto recommend the[vllm]extra, ensuring users get the correct dependencies for vLLM support. [1] [2]