add webshart format exporter#67
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for exporting captions to the "webshart" format, which writes caption data directly into existing webshart shard metadata JSON files. It also updates the CLI, exporter, and processor logic to handle this new format, and includes tests to ensure correct integration. Additionally, there are improvements to metadata handling in the webdataset processor and enhanced test coverage.
Webshart format support:
src/caption_flow/cli.py), documentation (README.md), and the exporter (src/caption_flow/storage/exporter.py). [1] [2] [3]to_webshart_metadatamethod inStorageExporterto write captions into webshart metadata JSON files using the webshart API.Webdataset processor improvements:
process_unitto include additional fields from the entry's metadata, such asjson_pathand other custom metadata, while avoiding duplication of standard fields. [1] [2] [3]Testing and validation:
These changes collectively enable seamless export of caption data into webshart metadata files, improve metadata handling, and ensure robust test coverage for the new and updated functionality.