[PM-37648] Fix double HTML encoding in emergency access emails#7652
Open
singhvishalkr wants to merge 1 commit into
Open
[PM-37648] Fix double HTML encoding in emergency access emails#7652singhvishalkr wants to merge 1 commit into
singhvishalkr wants to merge 1 commit into
Conversation
The SanitizeForEmail method HTML-encodes by default, but Handlebars templates also escape values. This caused names with special characters like umlauts to display as HTML entities (e.g. Windm&bitwarden#252;ller). Pass htmlEncode=false to match the pattern used elsewhere in this file.
|
|
Collaborator
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4845
When sending emergency access emails, names with special characters like German umlauts appear as HTML entities (e.g.,
Stephan Windmüllerinstead ofStephan Windmüller).The root cause is double HTML encoding:
CoreHelpers.SanitizeForEmail(name)encodes the name (htmlEncodedefaults totrue)Other email methods in the same file already pass
falseto avoid this (e.g.,SendProviderInviteEmailAsync). This change applies the same pattern to all emergency access email methods:SendEmergencyAccessInviteEmailAsyncSendEmergencyAccessConfirmedEmailAsyncSendEmergencyAccessRecoveryInitiatedSendEmergencyAccessRecoveryApprovedSendEmergencyAccessRecoveryRejectedSendEmergencyAccessRecoveryReminderSendEmergencyAccessRecoveryTimedOutTested by reviewing the code path and confirming the fix matches existing patterns.