[PM-37649] Fix admin panel web vault version fetch error handling#7653
Open
singhvishalkr wants to merge 1 commit into
Open
[PM-37649] Fix admin panel web vault version fetch error handling#7653singhvishalkr wants to merge 1 commit into
singhvishalkr wants to merge 1 commit into
Conversation
Behind reverse proxies, the request to fetch web vault version can fail in various ways that weren't previously handled: - Request timeouts (TaskCanceledException) - Invalid JSON responses (JsonException) - Missing 'version' property (KeyNotFoundException) - Non-success HTTP status codes (now logged as warning) All these scenarios now return a proper error message instead of silently failing or showing '-'.
|
|
Collaborator
|
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7142
The admin panel shows "Unable to fetch installed version" for the Web Vault version when running behind a reverse proxy. The
GetInstalledWebVersionmethod only catchesHttpRequestException, but proxies can cause other failure modes.The fix adds handling for:
TaskCanceledExceptionwhen the request takes too long (common behind slow proxies)JsonExceptionwhen the response isn't valid JSONKeyNotFoundExceptionwhen the response lacks a "version" fieldAll error paths now consistently return "Unable to fetch installed version" with a 500 status code, and each scenario is logged for debugging.