Feature/AM-51 - #135
Feature/AM-51#135ErickNaunay wants to merge 12 commits into
Conversation
…to feature/AM-51
|
SonarCloud Quality Gate failed.
|
jac1013
left a comment
There was a problem hiding this comment.
Looks good 👍 , minor comments to discuss/address.
| func configureUserManagerRoutes(restConfig userManagerRESTConfigurator, r *gin.Engine) *gin.Engine { | ||
| router := r.Group("/v1/users") | ||
|
|
||
| router.POST("/search", restConfig.findOne) |
There was a problem hiding this comment.
/search sounds like a big name for this, shouldn't be something like /find_by_email? (I don't know the convention that we are using for naming endpoints, consider that).
Another thing, I don't think this should be a POST, but a GET, are you doing this to prevent showing the email in the URL?
There was a problem hiding this comment.
Good point! I think the same /search is abig name for a simple endpoint
Yes, First tried to use GET but swagger denies all GET request with a body, they don't allow those calls. But also the email is sensitive information, therefore it shouldn't be visible on the URL
|
I need to fix whatever is pending here so I'll have to do this next week. |
Description
Expose user manager through the REST API
Stories
https://bixlabs.atlassian.net/browse/AM-51?atlOrigin=eyJpIjoiNTA3ZmRkMWUyMzZhNGM3Zjg1YWYxNDQ1NTMyZGNjMTAiLCJwIjoiaiJ9
List of changes
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
Impacted Areas in Application
Migrations
NO