fix(ci): improve workflow robustness, resolve registry path case issues, and pin base image - #1
Open
Piyush37-6 wants to merge 4 commits into
Open
fix(ci): improve workflow robustness, resolve registry path case issues, and pin base image#1Piyush37-6 wants to merge 4 commits into
Piyush37-6 wants to merge 4 commits into
Conversation
…solve syntax warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI/CD Workflows Robustness and Base Image Pinning
Summary
This pull request introduces several critical bug fixes, validation improvements, and reproducibility enhancements to the CI/CD workflows and the
bpyrunner image.Specifically, it:
${{in quotes, resolving YAML validation errors and red syntax highlights in IDEs.:latest: Introduces a configurablepush_latestparameter to prevent historical or manual release builds from overwriting the primary:latestimage tag.images/<image_name>/Dockerfileexists, preventing wasting runner minutes on builds with misspelled inputs.bpy/Dockerfileto a stable Ubuntu release tag (act-22.04) instead of using the rolling:act-latesttag.Detailed Breakdown of Changes
🛠️ Workflows
.github/workflows/build-image.yml
push_latestboolean input (defaults totrue).Lowercase repo nameto safely convert the repository path (e.g.,Piyush37-6/runner-images) to lowercase.Generate tagswhich builds a clean, multiline tag string (avoiding leading indentation whitespaces) and outputs it todocker_tags.username,password) and step outputs (tags) in double quotes to satisfy strict YAML parsers..github/workflows/release.yml
push_latestinput to manual triggers (workflow_dispatch).parse-tagjob to inspect if the target image directory exists.::error::) ifimages/<image_name>/Dockerfiledoes not exist.🐳 Dockerfiles
ghcr.io/catthehacker/ubuntu:act-latestto the stable tagghcr.io/catthehacker/ubuntu:act-22.04to prevent upstream changes from silently breaking image builds.🔄 Before / After Comparison
1. GHCR Registry Case Sensitivity
${{ github.repository }}string caused build errors if the owner/repository contained uppercase letters (e.g.Piyush37-6/runner-images).Before: