Skip to content

Database fields too short #23

Description

@pjz

Currently Broker has:

phone_number_1        = Column(String(15))
phone_number_2        = Column(String(15))
skype                 = Column(String(30))
email                 = Column(String(15))

which strike me as a bit... short. Your demo data (in bootstrap/demo.ini) thinks so too, since it overflows the email field (len("user@blinktrade.com") is > 15).

My suggested fix is to make phone numbers 30 characters and skype and email 254 characters. I could submit a PR, but I don't know how you guys are doing schema change management so didn't want to trample on it and risk messing with someone's live database.

Also, the name field in DepositMethods should likely be increased to 30; the current 15 is overflowed by demo.ini's usps_money_order.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions