feat(client): export HTTPStatusError for typed status code checking#271
Merged
feat(client): export HTTPStatusError for typed status code checking#271
Conversation
Replaces unstructured error strings with a typed HTTPStatusError so callers can use errors.As to inspect the HTTP status code (e.g., to distinguish 403 Forbidden from other failures). Amp-Thread-ID: https://ampcode.com/threads/T-019db19f-c22c-7400-bb53-bc30f1034901 Co-authored-by: Amp <[email protected]>
joshfriend
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces unstructured
errors.Errorf("unexpected status code: %d", ...)with a typedHTTPStatusErrorstruct so callers can useerrors.Asto inspect the HTTP status code.This enables consumers (e.g., blox cache priming) to reliably distinguish 403 Forbidden from other failures without fragile string matching.