You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Backports #4036 into 1.4-dev: replaces network_interface_addresses[interface] with .get(interface, []) in core/services/ping/ping360_ethernet_prober.py:27 to avoid a KeyError when an interface is present in psutil.net_if_stats() but disappears before psutil.net_if_addrs() is called. Adds psutil == 5.7.2 (matching the version pinned across other 1.4-dev services) to core/services/ping/setup.py and to the workspace pyproject.toml, and ships a regression test (test_ping360_ethernet_prober.py) that patches psutil.net_if_stats / net_if_addrs to cover the missing-interface and empty-snapshot cases. The extra sys.path / sys.modules juggling in the test is necessary because 1.4-dev's root pytest collects other services' top-level modules (e.g. ardupilot_manager/exceptions.py) and is called out with a comment.
No further comments, nice job 👍
Generated by PR Review Bot. This is advisory, a human reviewer must still approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #4036 into 1.4.
Supersedes #4041 (recreated from fork
joaoantoniocardoso/BlueOS-dockerinstead of same-repo head).