Skip to content

[backport/1.4] frontend: Gate network and platform polling by FetchType - #4066

Open
joaoantoniocardoso wants to merge 1 commit into
bluerobotics:1.4-devfrom
joaoantoniocardoso:backports/1.4/gate-network-platform-polling
Open

[backport/1.4] frontend: Gate network and platform polling by FetchType#4066
joaoantoniocardoso wants to merge 1 commit into
bluerobotics:1.4-devfrom
joaoantoniocardoso:backports/1.4/gate-network-platform-polling

Conversation

@joaoantoniocardoso

@joaoantoniocardoso joaoantoniocardoso commented Jul 30, 2026

Copy link
Copy Markdown
Member

This is a backport of #4049 into 1.4.

@joaoantoniocardoso
frontend: store: Gate network and platform polling by FetchType
1226893 
Refcount SystemNetworkType and PlatformType like other system-info
polls, subscribe from Networking widgets / Network tab / HealthTray, and
keep a stable iface-name list so App tray widgets do not rebuild on
every speed update.
@joaoantoniocardoso
joaoantoniocardoso marked this pull request as ready for review July 30, 2026 02:42
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Straight backport of #4049 into 1.4-dev. Refcounts SystemNetworkType and PlatformType polling: drops the always-on fetchSystemNetworkTask (2 s) and gates fetchPlatformTask (5 s) behind subscribers, adds a stable network_interface_names list so the App tray widgets don't rebuild every 2 s, and adds subscribe/unsubscribe pairs to DevicePathHelper, HealthTrayMenu, VehicleInfo, Network.vue, and the Networking widget. File list, additions (96), and deletions (48) match the merged upstream PR exactly. Spot-checked consumers: every reader of system_information.platform (DevicePathHelper, HealthTrayMenu, VehicleInfo) and of system_information.system.network (Network.vue, widgets/Networking.vue) subscribes to the corresponding FetchType in mounted and unsubscribes in beforeDestroy.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickelectric patrickelectric Awaiting requested review from patrickelectric
@Williangalvani Williangalvani Awaiting requested review from Williangalvani
@nicoschmdt nicoschmdt Awaiting requested review from nicoschmdt
@joaomariolago joaomariolago Awaiting requested review from joaomariolago

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joaoantoniocardoso